Code Review Request: 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself

Kurchi Hazra kurchi.subhra.hazra at oracle.com
Fri Nov 11 10:57:21 PST 2011


Hi,

  As specified in the CR description, this is a bug in src/windows/java/net/PlainSocketImpl.java and impl.socketSetOption() should be called instead of socketSetOption().

  This bug did not create a problem yet since setOption() is usually called for setting socket options.

Submitting hg diff:

   diff --git a/src/windows/classes/java/net/PlainSocketImpl.java b/src/windows/classes/java/net/PlainSocketImpl.java
--- a/src/windows/classes/java/net/PlainSocketImpl.java
+++ b/src/windows/classes/java/net/PlainSocketImpl.java
@@ -314,7 +314,7 @@ class PlainSocketImpl extends AbstractPl

      void socketSetOption(int cmd, boolean on, Object value)
          throws SocketException {
-        socketSetOption(cmd, on, value);
+        impl.socketSetOption(cmd, on, value);
      }

      int socketGetOption(int opt, Object iaContainerObj) throws SocketException {

Thanks,

-- 
-Kurchi





More information about the net-dev mailing list