Question about getaddrinfo in Inet4AddressImpl.c

Mike Duigou mike.duigou at oracle.com
Fri Nov 11 12:07:44 PST 2011


Some comments:

Inet4AddressImpl.c:

- why use bzero rather than posix memset?
- MAXHOSTNAMELEN is used. Shouldn't this be NI_MAXHOST as in the Inet6 version?

Mike


On Nov 11 2011, at 06:53 , Neil Richards wrote:

> On Wed, 2011-11-09 at 12:19 +0800, Charles Lee wrote:
>> On 11/09/2011 03:25 AM, Chris Hegarty wrote:
>>> Charles,
>>> 
>>> Is it possible to fix up the style issues, etc that Neil pointed out, 
>>> and have the webrev updated?
>>> 
> <snip>
>> Hi Chris,
>> 
>> Here it is. (attached)
>> 
> 
> And here it is, in webrev form [1].
> 
> Regards, Neil
> 
> [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.01/
> 
> -- 
> Unless stated above:
> IBM email: neil_richards at uk.ibm.com
> IBM United Kingdom Limited - Registered in England and Wales with number 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
> 




More information about the net-dev mailing list