Code Review 7041800: URI.equals may incorrectly return true with escaped octets

Alan Bateman Alan.Bateman at oracle.com
Thu Sep 1 02:27:16 PDT 2011


Chris Hegarty wrote:
>
> An embarrassing bug in the equal(String,String) private implementation 
> method. The Strings compare equal when there is a % in one string, a 
> different char in the same place in the other string, but the two 
> chars following are the same.
>
> http://cr.openjdk.java.net/~chegar/7041800/webrev.00/webrev/
>
> -Chris.
The fix looks fine. For the test then I think it would be better to add 
it to the existing unit test rather than adding a new test.

-Alan.



More information about the net-dev mailing list