Code Review Request: 7090158 Networking Libraries don't build with javac -Werror

[Kurchi Hazra]

3. java/net/DatagramSocket.java and java/net/MulticastSocket.java have
some real code changes around bind(). Maybe they should go to another fix?

I think there is some merging problem in my workspace. I will probably 
start with an updated copy of these files and insert my changes in them.

>> Some comments:
>>
>> 1. make/java/Makefile has no real change
>>
>> 2. make/javax/others/Makefile has only a new commented line
>>
>>
>> 4. sun/net/www/MessageHeader.java:
>>
>> 231 for(Map.Entry<String, List<String>> entry : include.entrySet()) {
>>
>> There should be a blank between "for" and "(", but probably not
>> necessary between "String," and "List" or "entry" and ":". You decide.


Will take care of these and post a new webrev.


>>
>> 234 l = new ArrayList<>();
>>
>> Do we have a consensus on whether diamond can be used here? i.e.
>> assignment not on declaration.
>>
>>


Waiting for someone's input on this. In retrospect, I feel this is not 
exactly how the diamond operator is meant to be used when I refer to 
http://download.oracle.com/javase/7/docs/technotes/guides/language/type-inference-generic-instance-creation.html, 
although this particular situation has not been commented upon.


Thanks,
Kurchi