Code review: 7079012 test/java/net/NetworkInterface/NetParamsTest.java fails with SocketException getting mac address

[Chris Hegarty]

On 21/09/2011 11:33, Alan Bateman wrote:
> Michael McMahon wrote:
>> Could I get the following webrev reviewed please?
>>
>> http://cr.openjdk.java.net/~michaelm/7079012/webrev.1/
>>
>> We're getting an unexpected error in native code on Solaris when calling
>> the ioctl() that returns hardware MAC addresses for certain kinds of
>> NetworkInterface.
>> So, the fix is not to throw an exception, but to return a null byte[]
>> instead.
>>
>> The fix also adds support for the new Solaris 11 SIOCGLIFHWADDR ioctl()
>>
>> Thanks,
>> Michael.
> This looks fine to me.

Thumps up from me too.

-Chris.

>
> -Alan