Problem with getFlags() method in NetworkInterface.c

[Chris Hegarty]

Shirish,

There were some minor issues with your patch ( it did not build on all 
platforms ). I fixed these issues and also updated the Mac variant of 
getFlags. It now compiles and runs on all platforms.

The test has been dropped ( as I indicated in the previous mail ).

http://cr.openjdk.java.net/~chegar/7190254/webrev.00/webrev/

If Neil ( or someone else from IBM ) is to push this, you can grab the 
patch from the above webrev (and list me as a reviewer). Otherwise, I 
can push it for you.

-Chris.

On 09/08/2012 15:38, Shirish Kuncolienkar wrote:
> Chris,
>
> Please go ahead and run the sanity builds and tests.
>
> Thanks
> -Shirish
>
> On 8/9/2012 7:52 PM, Chris Hegarty wrote:
>>
>> On 09/08/12 14:16, Shirish Kuncolienkar wrote:
>>> ....
>>> I agree there is no general documentation available, AIX defines vipa
>>> interface flag as "0x80000000"
>>
>> In which case I don't see any problems with your proposed source
>> changes. One could argue that maybe they should go through the
>> specific porting project ( since it's not directly relevant to
>> existing supported platforms ), but I see this more of a clean up
>> exercise. No need to carry such a trivial change in a project sub repo.
>>
>> Usually a new testcase is recommended, but in this case the
>> functionality ( isUp, isXXX() ) is already exercised by many many
>> tests so I think we can leave it to the other tests.
>>
>> I filed a new bug to track this issue,
>> CR 7190254: "NetworkInterface getFlags implementation should support
>> full integer bit range for flags value."
>>
>> If you don't mind, I would like to take your patch to
>> NetworkInterface.c and run some sanity builds and tests on it. I'd
>> hope to get this done later today or early tomorrow.
>>
>> -Chris.
>>
>>> Here is a similar bug report related to FreeBSD
>>> http://hg.openjdk.java.net/macosx-port/macosx-port/jdk/rev/c6334146005c.
>>> A different fix was proposed here.
>>>
>>> Hope this helps.
>>>
>>> Thanks
>>> -Shirish
>>>
>>
>
>