Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c'

[Chris Hegarty]

Christian,

I finally got back to this.

Since init() is only ever called from the class initializer it is 
implicitly single threaded, so we only need to add the synchronized 
keyword to getSystemProxy().

I also added a test for completeness. Here is the final webrev that I 
intend to push ( listing 'Christian Schulte <cs at schulte.it>' as the 
contributor ).

http://cr.openjdk.java.net/~chegar/7188755/webrev.00/webrev/

-Chris.

On 03/08/2012 06:53, Christian Schulte wrote:
> Am 08/02/12 17:27, schrieb Chris Hegarty:
>> Thanks for the cross post David. Yes, net-dev is the best place to
>> discuss this issue ( bcc'ing off jdk7u-dev ).
>>
>> Thanks for reporting this issue Christian. I haven't looked at the
>> proposed patch yet, but I agree we may want to simplify this if possible
>> ( handling the synchronization at the Java level ). We also need to add
>> support for gnome3 system proxies in the near future. We need to ensure
>> we don't further complicate that.
>
> The attached patch moves synchronization to the Java level for all
> platforms and also solves the issue here.
>
> Regards,
>