Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c'
Chris Hegarty
chris.hegarty at oracle.com
Fri Aug 10 09:53:55 PDT 2012
On 10/08/12 17:28, Alan Bateman wrote:
> On 10/08/2012 17:10, Chris Hegarty wrote:
>> Christian,
>>
>> I finally got back to this.
>>
>> Since init() is only ever called from the class initializer it is
>> implicitly single threaded, so we only need to add the synchronized
>> keyword to getSystemProxy().
>>
>> I also added a test for completeness. Here is the final webrev that I
>> intend to push ( listing 'Christian Schulte <cs at schulte.it>' as the
>> contributor ).
>>
>> http://cr.openjdk.java.net/~chegar/7188755/webrev.00/webrev/
>>
>> -Chris.
> The change looks good to me. The test is fine took although I assume if
> any of the threads through an exception then it will not cause the test
> to fail (but of course if they crash it will).
Right, the issue is a crash in native code. I tried it with jtreg and it
fails most of the time ( without the fix ). The test will not do
anything else useful. It should be fine.
-Chris.
>
> -Alan
More information about the net-dev
mailing list