Infinite Loop in KeepAliveStream

Chris Hegarty chris.hegarty at oracle.com
Sun Dec 16 06:05:21 PST 2012


On 15/12/2012 01:56, Martin Buchholz wrote:
> ...
>
> I was trying to avoid ever calling skip with a larger argument than
> available(), trying to obey the comment
> // Do this ONLY if the skip won't block.
> So my version feels safer, although again I don't have the full context.

OK, makes sense. I'm ok with your version. This code seems to have been 
written with thread-safety "half" in mind, your change is probably the 
safest.

Can you also include the test in the changeset? Or do you want me to 
push it for you?

-Chris.



More information about the net-dev mailing list