Code Review Request: 7127771: (macosx)test/java/net/Socket/TrafficClass.java fails on Mac OS X
Michael McMahon
michael.x.mcmahon at oracle.com
Wed Jan 18 07:56:54 PST 2012
Looks fine.
- Michael.
On 17/01/12 19:01, Kurchi Hazra wrote:
> I updated the comment:
> http://cr.openjdk.java.net/~khazra/7127771/webrev.02/
>
> - Kurchi
>
>
>
> On 1/16/2012 2:43 AM, Michael McMahon wrote:
>> Yes, looks fine to me too. I would just update the comment above this
>> code to add Mac OS to the Solaris case.
>>
>> Thanks
>> Michael
>>
>> On 13/01/12 21:02, Kurchi Hazra wrote:
>>> How does this look:
>>> http://cr.openjdk.java.net/~khazra/7127771/webrev.01/
>>>
>>> - Kurchi
>>>
>>>
>>>
>>> On 1/13/2012 12:14 PM, Alan Bateman wrote:
>>>>
>>>>>> Bug : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127771
>>>>>> Webrev : http://cr.openjdk.java.net/~khazra/7127771/webrev.00/
>>>> What you have is fine although you could combine with the Solaris
>>>> code? Should the __ALLBSD_SOURCE XXX be removed while you are there?
>>>>
>>>> -Alan
>>>
>>
>
More information about the net-dev
mailing list