Code Review Request: 7171591: getDefaultScopeID() in src/solaris/native/java/net/net_util_md.c should return a value

Alan Bateman Alan.Bateman at oracle.com
Fri May 25 12:11:05 PDT 2012


On 25/05/2012 20:07, Kurchi Hazra wrote:
> Hi,
>
>    This is an oversight in the fix for 7144274, where I introduced a 
> method
> getDefaultScopeID() to retrieve the default scope id in Mac OS X. The 
> macro
> used for checking whether the variable passed is null should return an 
> integer
> value, since the method getDefaultScopeID() is declared to return an int.
>
> Bug: http://bugs.sun.com/view_bug.do?bug_id=7171591 (Not available yet)
> Webrev: http://cr.openjdk.java.net/~khazra/7171591/webrev.00/
Looks okay to me, I assume found by observation rather than a crash.

-Alan.



More information about the net-dev mailing list