Review request for bug number: 6354758, aka "rename old test HttpServer classes"

John Zavgren john.zavgren at oracle.com
Wed Sep 5 09:26:38 PDT 2012


Kurchi:

That is a mistake.

I'll change the HTTPS name right now... and create a new webrev image.

Thanks!
John Zavgren
----- Original Message -----
From: kurchi.subhra.hazra at oracle.com
To: john.zavgren at oracle.com
Cc: net-dev at openjdk.java.net
Sent: Wednesday, September 5, 2012 11:54:01 AM GMT -05:00 US/Canada Eastern
Subject: Re: Review request for bug number: 6354758, aka "rename old test HttpServer classes"

Looks good John. Any particular reason that you renamed HttpServer to 
TestHttpServer
but HttpsServer to SimpleHttpsServer?

Thanks,
- Kurchi

On 9/5/12 7:39 AM, John Zavgren wrote:
> Greetings:
>
> Please help to review the fix below for bug 6354758:
> http://cr.openjdk.java.net/~chegar/6354758/webrev.00/
>
> I changed the name of the class: ./test/sun/net/www/httptest/HttpServer.java to: ./test/sun/net/www/httptest/TestHttpServer.java,
> to eliminate a possible "name space collision". The server in the test code (which is intended to be used ONLY for testing) has the same name as the server that's used as an actual Http Server:
> ./jdk/src/share/classes/com/sun/net/httpserver/HttpServer.java
>
> Thanks,
> John Zavgren




More information about the net-dev mailing list