request for review: 7199219: Proxy-Connection headers set incorrectly when a HttpClient is retrieved from the Keep Alive Cache

Chris Hegarty chris.hegarty at oracle.com
Fri Sep 21 02:37:09 PDT 2012


Thanks Rob, I missed this when adding the tunneling state way back.

I guess a test would be a little convoluted here, I'm ok to add 
noreg-hard ( hard to write a new automatic regression test) to the CR.

-Chris.

On 20/09/12 16:14, Rob McKenna wrote:
> Hi folks,
>
> Looking for a review for:
>
> 7199219: Proxy-Connection headers set incorrectly when a HttpClient is
> retrieved from the Keep Alive Cache
>
> http://cr.openjdk.java.net/~robm/7199219/webrev.01/
> <http://cr.openjdk.java.net/%7Erobm/7199219/webrev.01/>
>
> Basically we never set the correct TunnelState after retrieving a
> connection from the KeepAliveCache. This leads to incorrect connection
> headers being set in the request. (in HttpURLConnection.writeRequests())
>
>      -Rob



More information about the net-dev mailing list