DefaultProxySelector socks override
Christos Zoulas
christos at zoulas.com
Tue Apr 2 18:26:16 PDT 2013
On Apr 2, 5:13pm, kurchi.subhra.hazra at oracle.com (Kurchi Hazra) wrote:
-- Subject: Re: DefaultProxySelector socks override
| Hi Christos/Chris,
|
| Here is a webrev for this change:
| http://cr.openjdk.java.net/~khazra/5001942/webrev.00/
LGTM, for DefaultProxySelector.java.
The SocksProxyVersion.java change should be under a different commit
message and revision since it does not have anything to do with socks;
here you are just factoring out the "localhost" name to address resolution,
which is nice and worthwhile, but not for the same commit.
Thanks,
christos
More information about the net-dev
mailing list