DefaultProxySelector socks override

[Kurchi Subhra Hazra]

Alright, thanks, I'll push it today.

- Kurchi

On 4/4/13 1:33 AM, Chris Hegarty wrote:
> I'm happy to go with what you have Kurchi.
>
> -Chris.
>
> On 04/04/2013 01:57 AM, Kurchi Subhra Hazra wrote:
>> So the default non-proxy hosts are localhost|127.*|[::1]|0.0.0.0|[::0].
>> There can thus be a problem only if the local machine is being used as a
>> proxy, which will be
>> unlikely in real environments.
>>
>> We could go a step further and allow setting socksNonProxyHosts to ""
>> (an empty string) to override the default. I am
>> not sure if it is required though.
>>
>> - Kurchi
>>
>> On 4/3/13 9:55 AM, Chris Hegarty wrote:
>>> Thank you Kurchi for taking this in, and running/updating the test.
>>>
>>> Do you think that anyone might be surprised by this change, like our
>>> test was? Wanting to proxy connections to the localhost seems more
>>> like testing environments rather than deployment.
>>>
>>> -Chris.
>>>
>>> On 04/03/2013 01:13 AM, Kurchi Hazra wrote:
>>>> Hi Christos/Chris,
>>>>
>>>>     Here is a webrev for this change:
>>>> http://cr.openjdk.java.net/~khazra/5001942/webrev.00/
>>>>
>>>> Thanks,
>>>> - Kurchi
>>>>
>>>>
>>>>
>>>> On 3/27/2013 10:49 AM, christos at zoulas.com wrote:
>>>>> On Mar 27,  5:30pm, chris.hegarty at oracle.com (Chris Hegarty) wrote:
>>>>> -- Subject: Re: DefaultProxySelector socks override
>>>>>
>>>>> | On 03/27/2013 05:22 PM, christos at zoulas.com wrote:
>>>>> | > ....
>>>>> | > Sure, I just requested a subscription to net-dev so I might not
>>>>> see the
>>>>> | > first few messages. To clarify:
>>>>> | >
>>>>> | >     1. I will add socks.proxyHost and socks.proxyPort for
>>>>> consistency
>>>>> | >        with the other protocols, leaving as is socksProxyHost and
>>>>> | >        socksProxyPort for compatibility.
>>>>> | >     2. I will add socks.nonProxyHosts and not socksNonProxyHosts.
>>>>> | >
>>>>> | > Is that what you had in mind?
>>>>> |
>>>>> | Re-checking the code I take back my previous comment. We already 
>>>>> have
>>>>> |
>>>>> |     socksProxyHost, socksProxyPort, socksProxyVersion
>>>>> |
>>>>> | so your original proposal of 'socksNonProxyHosts' is probably
>>>>> best, and
>>>>> | consistent with existing properties.
>>>>>
>>>>> I concur. Nothing for me to do :-)
>>>>>
>>>>> Best,
>>>>>
>>>>> christos
>>>>
>>