RFR: 8023326 [TESTBUG] java/net/CookieHandler/LocalHostCookie.java misplaced try/finally

Chris Hegarty chris.hegarty at oracle.com
Sun Aug 25 01:31:38 PDT 2013


Looks ok to me Mark.

-Chris.

On 08/21/2013 02:37 PM, Mark Sheppard wrote:
> Hi
> please oblige and review the fix below to address the issue in JDK-8023326
> which makes the test more robust to certain exceptions thrown.
>
> http://cr.openjdk.java.net/~msheppar/8023326/webrev/
>
> regards
> Mark
>
> --- old/test/java/net/CookieHandler/LocalHostCookie.java    Wed Aug 21
> 12:23:21 2013
> +++ new/test/java/net/CookieHandler/LocalHostCookie.java    Wed Aug 21
> 12:23:21 2013
> @@ -72,7 +72,9 @@
>                   }
>               }
>           } finally {
> -            s.stopServer();
> +            if (s != null) {
> +                s.stopServer();
> +            }
>           }
>       }
>
> @@ -96,7 +98,9 @@
>           }
>
>           public void stopServer() {
> -            server.stop(0);
> +            if (server != null) {
> +                server.stop(0);
> +            }
>           }
>       }
>
>
>



More information about the net-dev mailing list