RFR: java/net/MulticastSocket/SetGetNetworkInterfaceTest.java throws java.net.SocketException: Cannot assign requested address

[Chris Hegarty]

On 23 Dec 2013, at 18:21, Mark Sheppard <mark.sheppard at oracle.com> wrote:

> Hi,
>   Please oblige and review the following changes:
> 
> http://cr.openjdk.java.net/~msheppar/8027903/webrev/
> 
> which address the issue:
> 
> https://bugs.openjdk.java.net/browse/JDK-8027903
> 
> The test failure was found to be due to an interface configured with an IPv6 address and
> no IPv4 address. The native code was calling mcast_set_if_by_addr_v4(...), which
> raised an exception. The native code in src/solaris/native/java/net/PlainDatagramSocketImpl.c was amended to
> check for a pending exception, and clear it prior to executing the ipv6 function, in the ipv6 conditional block.

Looks good to me. If the IPv6 version completes successfully then there clearly is no reason to throw an exception. If it does not, then there will be a new exception on the stack.

-Chris.

> 
> regards
> Mark