8007322: make ftp regression tests optional

[Chris Hegarty]

On 01/02/2013 11:27, Alan Bateman wrote:
> On 31/01/2013 22:16, Chris Hegarty wrote:
>> Given the recent downgrade of the ftp handler by 8000941: "Remove ftp
>> from the required list of protocol handlers", the regression tests
>> that exercise the ftp protocol handler should be made optional. This
>> will make testing the smallest profile and the base module easier (
>> rather than trying to exclude individual tests ).
>>
>> http://cr.openjdk.java.net/~chegar/8007322/webrev.00/webrev/
>>
>> Alan,
>> I hacked the ftp classes out of a full build to test this. You may
>> want to try the patch with a profiles build. All the jdk_net tests
>> should pass.
> Thanks for doing this.
>
> If you want to build the profile images yourself then just clone
> jdk8/profiles forest, the make target is "profiles". David Holmes is
> planning to push this to jdk8 later in the month.

Yes, I will do this to confirm all is ok with the net tests and small 
profiles.

> I see you've updated tests in test/sun/net/ftp or
> test/sun/net/www/protocol/ftp and I don't think that is strictly needed
> as they are straight-forward to exclude as not-applicable directories.

OK, either way is fine to me.

> I see that hasFTP catches IOException in many places, I assume this
> should be MalformedURLException.

Yes, I will update it.

 > I guess I would rename it to hasFtp but that's a minor point.

Yes, probably better.

> Should test/sun/www/MarkResetTest* be moved to the ftp directory as it
> is an ftp specific test?

Yes, I will move it.

> The big refactoring seems to the URL/Constructor.java, looks like you've
> moved all the test cases into the java file. The update looks reasonable
> to me, I guess I would have chosen something like TestCase rather than
> Entry but what you have is fine if you want to keep it.

OK, thanks,

-Chris.

>
> -Alan