RFR JDK8015799

[Kurchi Hazra]

On 6/26/2013 12:17 PM, Kurchi Hazra wrote:
> Hi John,
>
>   Why not change lines 2810-2811 to:
>     if (value == null || value.length() == 0)
>         return value;
I meant return null. For other cookie-headers too, is there any reason 
for us not returning null if the length of value is 0?
>
> Also, lots of formatting issue in the test, especially in 
> TestCookieHandler, try-catch block indentation is off in line 54.
>  Its also best to stop the server in a finally clause at line 58. 
> Alternatively, I also liked Andreas' use of autocloseable in his test 
> for 6563286. See [1].
>
> - Kurchi
>
> [1] 
> http://cr.openjdk.java.net/~arieber/6563286/webrev.00/test/sun/net/www/http/HttpURLConnection/MalformedFollowRedirect.java.html 
> <http://cr.openjdk.java.net/%7Earieber/6563286/webrev.00/test/sun/net/www/http/HttpURLConnection/MalformedFollowRedirect.java.html>
>
> On 6/26/2013 10:54 AM, John Zavgren wrote:
>> Please consider the following changes to the Java cookie code.
>>
>> http://cr.openjdk.java.net/~jzavgren/8015799/webrev.02/ 
>> <http://cr.openjdk.java.net/%7Ejzavgren/8015799/webrev.02/>
>>
>> The problem I fixed occurs when a server returns an array of cookies 
>> that contains a null cookie.
>>
>> Thanks
>> John
>> -- 
>> John Zavgren
>> john.zavgren at oracle.com
>> 603-821-0904
>> US-Burlington-MA
>

-- 
-Kurchi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20130626/871a0243/attachment.html