答复: 答复: RFR for JDK-703666 test/com/sun/net/httpserver/Test9a.java fails intermittently

[Daniel Fuchs]

On 11/20/13 1:32 PM, Tristan Yan wrote:
> Oops, I must have bumped my head.
> Thanks for point this out.
> http://cr.openjdk.java.net/~ewang/tristan/JDK-7036666/webrev.00/
> Tristan

Looks good!

-- daniel

>
> -----邮件原件-----
> 发件人: Daniel Fuchs
> 发送时间: Wednesday, November 20, 2013 8:12 PM
> 收件人: Tristan Yan; Chris Hegarty; net-dev at openjdk.java.net
> 主题: Re: 答复: RFR for JDK-703666 test/com/sun/net/httpserver/Test9a.java fails intermittently
>
> On 11/20/13 12:42 PM, Tristan Yan wrote:
>> Thanks Chris and Daniel
>> I change 'clientCtx' to final and error with volatile.
>
> Unless I'm mistaken this should not compile because of line 60:
>
>     44     static final SSLContext clientCtx = null;
>     ...
>     60             clientCtx = new
> SimpleSSLContext(System.getProperty("test.src")).get();
>
> best regards,
>
> -- daniel
>
>
>> http://cr.openjdk.java.net/~ewang/tristan/JDK-7036666/webrev.00/
>> I'm appreciated Chris be my sponsor for this.
>> Thank you.
>> Tristan
>>
>> -----邮件原件-----
>> 发件人: Chris Hegarty
>> 发送时间: Wednesday, November 20, 2013 6:49 PM
>> 收件人: Daniel Fuchs; Tristan Yan; net-dev at openjdk.java.net
>> 主题: Re: RFR for JDK-703666 test/com/sun/net/httpserver/Test9a.java
>> fails intermittently
>>
>> On 20/11/13 10:19, Daniel Fuchs wrote:
>>> Hi Tristan,
>>>
>>> I believe you should also declare the 'error' flag as well as the
>>> 'clientCtx' variable volatile since they are set by a thread and read
>>> by another.
>>
>> Good catch Daniel. Tristan, can you update the webrev and create a changeset. I can then sponsor this change for you.
>>
>> Thanks,
>> -Chris.
>>
>>
>>
>>>
>>> best regards,
>>>
>>> -- daniel
>>>
>>> On 11/20/13 5:59 AM, Tristan Yan wrote:
>>>> /Hi All/
>>>>
>>>> /I am working on https://bugs.openjdk.java.net/browse/JDK-7036666,
>>>> this bug was opened 3 years ago and test was put into ProblemList. I
>>>> ran a
>>>> 1000 times loop to try to reproduce the failure but I got no luck.
>>>> Also I use same jdk binaries run all regression tests a couple of
>>>> hundred time I don’t see any failure on this test either./
>>>>
>>>> /I suggest we bring this test back from ProblemList and add a debug
>>>> info for only possible failure place./
>>>>
>>>> //
>>>>
>>>> /http://cr.openjdk.java.net/~ewang/tristan/JDK-7036666/webrev.00//
>>>>
>>>> //
>>>>
>>>> /Please let me know if you have any suggestion or comments./
>>>>
>>>> //
>>>>
>>>> /Tristan Yan(Haibo Yan)/
>>>>
>>>> //
>>>>
>>>
>