RFR:JDK-8021372 NetworkInterface.getNetworkInterfaces() returns duplicate hardware address

Chris Hegarty chris.hegarty at oracle.com
Wed Sep 4 03:39:45 PDT 2013


Mark,

The source changes look good to me.

The test is a good addition, but trivially I would...
  1) remove the @build and @run tags. I don't think they are needed
     as I don't see that the test needs to run in othervm mode.
  2) remove all exception handling code, and just declare all methods
     to throw Exception. The jtreg harness will show the test as failed
     if an unhandled exception is thrown.

-Chris.

On 04/09/2013 08:59, Mark Sheppard wrote:
> Hi
> based on feedback for initial fix, an amended webrev has been created.
> So, please oblige and review the fix below to address the issue in
> JDK-8021372: NetworkInterface.getNetworkInterfaces() returns duplicate
> hardware address
>
> webrev:
> http://cr.openjdk.java.net/~msheppar/8021372/webrev.01/
>
> regressions re-run with no ill effects
>
> regards
> Mark



More information about the net-dev mailing list