RFR : 8024952 : ClassCastException in PlainSocketImpl.accept() when using custom socketImpl

[Seán Coffey]

Dmitry,

You're right. I was cautious in moving the code up but since we're 
pointing at FileDescriptor Objs, we should be ok.

Daniel Fuchs has pointed out another issue. Null delegate being passed 
into impl.accept if dealing with a custom socketImpl! It should just be 
impl.accept(s); I'll get this corrected and tested.

Thanks for pointers.
Sean.

On 20/09/13 10:20, Dmitry Samersoff wrote:
> Sean,
>
> It might be possible to set s.fd to delegate.fd before call to
> impl.accept and therefore merge if instanceOf block.
>
> -Dmitry
>
> On 2013-09-20 00:21, Seán Coffey wrote:
>> Looking for review on recently reported issue. Issue seen on windows
>> when a custom socketImpl is in use.
>>
>> bug report : https://bugs.openjdk.java.net/browse/JDK-8024952
>> webrev : http://cr.openjdk.java.net/~coffeys/webrev.8024952/webrev/
>>
>> Regards,
>> Sean.
>>
>