RFR [9] 8039362: Read content-types.properties as a resource

Chris Hegarty chris.hegarty at oracle.com
Tue Apr 8 13:15:16 UTC 2014


Updated webrev to include Mandy’s and Alan’s comments:

  http://cr.openjdk.java.net/~chegar/8039362/02/webrev/

On 7 Apr 2014, at 22:50, Mandy Chung <mandy.chung at oracle.com> wrote:

> ….
> 
> line 225: since content-types.properties is moved to the same package as MimeType class, you can simply use the relative path "content-types.properties" to get the resource stream

Done.

> line 240: should we expect it always exist?  Perhaps an assert.

I decided to throw InternalError. There is a code or build problem if this ever happens

> I wonder if this can be refactored so that it can use try-with-resources.

Done.

-Chris.

> thanks
> Mandy



More information about the net-dev mailing list