RFR: 8036979: Support java.net.SocketOption<> in java.net socket types

[Michael McMahon]

Thanks Chris.

Michael.

On 09/04/14 13:34, Chris Hegarty wrote:
> This is a nice addition, and looks very good to me.
>
> Just a few small comments:
>
> 1) SocketImpl getOption/setOption need javadoc to describe how they can
>    throw IOException. Maybe even the same, of similar javdoc to the
>    socket type equivalent methods?
>
> 2) New protected methods in SocketImpl need an @since tag.
>
> -Chris.
>
> On 08/04/14 18:49, Michael McMahon wrote:
>> Could I get the following reviewed please?
>>
>> In addition to providing generic support for java.net.SocketOption,
>> it also includes 8032808, which implements a platform specific
>> socket option SO_FLOW_SLA (in jdk.net)
>>
>> There are changes to two repos:
>>
>> http://cr.openjdk.java.net/~michaelm/8036979/jdk/01/
>>
>> and
>>
>> http://cr.openjdk.java.net/~michaelm/8036979/top/01/webrev/
>>
>> Thanks
>> Michael
>>