RFR(S): 8055032: Improve numerical parsing in java.net and sun.net
Alan Bateman
Alan.Bateman at oracle.com
Thu Aug 14 11:30:47 UTC 2014
On 14/08/2014 10:32, Claes Redestad wrote:
> :
>
> Any particular place where you think readability becomes a problem?
> I've grown fond of the
> parseInt(s, radix, offset) form myself, but I'm biased. ;-)
It's somewhat subjective but when a method has a sequence of parameters
that are the same type (int in this case) then reading the code requires
a bit of extra effort to match up the parameters.
Looking at this again then I just wonder if the radix should be last
parameter rather than having it appear before the range. I think it
would be clearer if the range were to follow the CharSequence rather
than having the radix appear in the middle. I didn't have cycles to
follow the recent discussion/review on core-libs-dev when these methods
were added. Did the ordering come up?
-Alan.
More information about the net-dev
mailing list