RFR 8042581: Intermittent failure in java/net/DatagramSocket/InheritHandle.java
FELIX YANG
felix.yang at oracle.com
Tue Dec 30 05:43:30 UTC 2014
Thanks for looking at this, Alan and Chris. Please check the updated
webrev:
http://cr.openjdk.java.net/~xiaofeya/8042581/webrev.01/
-Felix
On 12/29/2014 11:51 PM, Alan Bateman wrote:
> On 29/12/2014 15:46, Chris Hegarty wrote:
>> Looks ok Felix.
>>
>> You could put the construction of the new DatagramSocket in a
>> try-with-resources, so it will be closed always, even if the test fails.
>>
>> -Chris
> I agree with Chris' comment. One other thing is that testing if e
> instanceof BindException is not necessary as e will always be a
> BindException.
>
> -Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20141230/2147612f/attachment.html>
More information about the net-dev
mailing list