Re: RFR (XS) [9] PlainDatagramSocketImpl missing returns after “throwing an exception”

Michael McMahon michael.x.mcmahon at oracle.com
Wed Feb 5 05:02:22 PST 2014


Looks good.

- Michael.

On 05/02/14 09:58, Chris Hegarty wrote:
> Some very minor clean up in PlainDatagramSocketImpl to add some missing returns after “throwing an exception”, as well as checking for a pending exception after calling setTTL ( that can throw ).
>
> http://cr.openjdk.java.net/~chegar/nativeInetCleanup/webrev.02/webrev/src/solaris/native/java/net/PlainDatagramSocketImpl.c.sdiff.html
>
> -Chris.
>
> P.S. This is not a comprehensive audit of this file, just some issues I noticed while refactoring some of he InetAddress fieldIDs yesterday.



More information about the net-dev mailing list