RFR for bug JDK-8035633 TEST_BUG: java/net/NetworkInterface/Equals.java and some tests failed on windows intermittently

[Ivan Gerasimov]

Hello Eric

Would you please also correct the comment on the line above your change:
s/seudo/pseudo/

The typo is in all three files.

Sincerely yours,
Ivan


On 27.02.2014 12:18, Eric Wang wrote:
> On 2014/2/25 16:59, Alan Bateman wrote:
>> On 25/02/2014 08:49, Eric Wang wrote:
>>> Hi Everyone,
>>>
>>> I'm working on the test bug 
>>> https://bugs.openjdk.java.net/browse/JDK-8035633, There are 4 tests 
>>> (one is in a closed test) failed due to NullPointerException.
>>> All tests failed at similar places "if (isWindows && 
>>> ni.getDisplayName().contains("Teredo"))", the root cause is the 
>>> NetworkInterface may return null if no display name is available.
>>> so the fix is to make sure the display name is not null before 
>>> calling the method "contains("Teredo")", something like "if 
>>> (isWindows && displayName != null && displayName.contains("Teredo"))"
>>>
>>> Please let me know if you have any comment. The webrev will be sent 
>>> after internal review.
>> Yes, NetworkInterface's getDisplyName is allowed to return null and 
>> it looks like this wasn't taken into account when these tests were 
>> changed via JDK-8022963 to skip tunnels. Once you have a patch then 
>> net-dev would be the best list to bring it to.
>>
>> -Alan.
>
> Thanks Alan to suggest the correct alias!
> Below is the webrev for this bug, Can you or anyone else help to 
> review the fix?
> http://cr.openjdk.java.net/~ewang/JDK-8035633/webrev.00/ 
> <http://cr.openjdk.java.net/%7Eewang/JDK-8035633/webrev.00/>
>
> There is one more closed test fixed, it will be sent in another mail.
>
> Thanks,
> Eric
>
>