RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

Volker Simonis volker.simonis at gmail.com
Wed Jan 15 03:05:14 PST 2014


On Wed, Jan 15, 2014 at 10:03 AM, Alan Bateman <Alan.Bateman at oracle.com>wrote:

> On 15/01/2014 06:24, David Holmes wrote:
>
>>
>> I'm not a fan of runtime checks of this kind though if it is only a very
>> samll number of values it might be okay.
>>
>> Another option would be to make those classes into "templates" as done
>> with Version.java.template and substitute the right values at build time.
>>
>> But I'll let Alan and net-dev folk come back with their preferred
>> technique for this.
>>
>>  I plan to spend time on Volker's webrev later in the week (just too busy
> with other things right now). For the translation issue then it's an
> oversight in the original implementation, it just hasn't come up before (to
> my knowledge anyway). The simplest solution here maybe to to just move them
> to sun.net.ch.Net and have them initialized to their native value.


Do you mean sun.nio.ch.Net right?

Do you propose to completely remove the definitions of the POLL constants
from:

src/share/classes/sun/nio/ch/AbstractPollArrayWrapper.java
src/solaris/classes/sun/nio/ch/Port.java

and replace all their usages by Net.POLL* ?


> In general then I'm not too concerned about that one, it's the changes to
> support async close on AIX that are leaping out at me.
>
> -Alan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20140115/d0df4591/attachment-0001.html 


More information about the net-dev mailing list