RFR: 8048212 Two tests failed with "java.net.SocketException: Bad protocol option" on Windows after 8029607

Michael McMahon michael.x.mcmahon at oracle.com
Fri Jul 4 18:33:26 UTC 2014


On 30/06/14 19:43, Alan Bateman wrote:
> On 30/06/2014 17:53, Michael McMahon wrote:
>> Could I get the following change reviewed please?
>>
>> http://cr.openjdk.java.net/~michaelm/8048212/webrev.1/
>>
>> It fixes a problem caused by the fix for 8029607. The changes for
>> that fix should not have been applied to Windows. So, this fix ensures
>> that the IPv4 option is used always on Windows.
>>
> I don't know if Windows supports setting IP_TOS on an IPv6 socket but 
> in any case, it might be simplest to just go back to the original 
> behavior which was for this case to be a no-op. The spec allows for that.
>
> -Alan

Sorry for the delay in getting back to this.

The following is a simpler change that restores the original NIO 
behavior on Windows

http://cr.openjdk.java.net/~michaelm/8048212/webrev.2/

Michael


More information about the net-dev mailing list