RFR: JDK-8040810 - Uninitialised memory in jdk/src/windows/native/java/net: net_util_md.c, TwoStacksPlainSocketImpl.c, TwoStacksPlainDatagramSocketImpl.c, DualStackPlainSocketImpl.c, DualStackPlainDatagramSocketImpl.c

[Alan Bateman]

On 16/07/2014 18:00, Mark Sheppard wrote:
> Hi
>     please oblige and review the following changes
>
> http://cr.openjdk.java.net/~msheppar/8040810/webrev/
>
> which address the issue raised in
>
> https://bugs.openjdk.java.net/browse/JDK-8040810
>
> resulting from static code analysis.
>
> these changes explicitly initialize local function variables, which 
> are in the main
> out parameters to other function calls and hence are set within the 
> called function.
> It can be reasonably argued that the initialization is unnecessary, 
> but current coding
> guidance is to perform the initialization
>
I assume in NET_Bind that it isn't necessary to initialize rv, same 
thing in NET_SocketClose. Otherwise looks okay.

-Alan