[8u-dev] RFR: 8036979: Support java.net.SocketOption<> in java.net socket types

[Michael McMahon]

Does it matter that they are not in 1.8 FCS? Maybe it depends on the 
exact meaning
of @since. Does it refer to the JDK version, or the Java SE version? If 
the latter,
then we couldn't put them in these classes at all, which doesn't seem right.

Michael

On 04/06/14 10:12, Chris Hegarty wrote:
> Since these APIs are not in 1.8 FCS, is there another way to indicate 
> what release they were added in?
>
> -Chris.
>
> On 04/06/14 09:51, Michael McMahon wrote:
>> Hi Deven,
>>
>> Thanks for pointing that out. I'll see if we can fix it in time for 
>> 8u20.
>> In fact, it should really have the same value in JDK 9 as well.
>>
>> Michael
>>
>> On 03/06/14 08:48, Deven You wrote:
>>> Hi Michael,
>>>
>>> I have a small question here. I have roughly gone through the patch
>>> and find several javadoc indicate @since 1.9.
>>>
>>> Since it is an 8u20 patch, I wonder if we should change @since 1.9 to
>>> @since 1.8 for both 8u20 and java8?
>>>
>>> I could provide a patch to change @since 1.9 to @since 1.8 if this is
>>> what we want.
>>>
>>> Thanks a lot!
>>>
>>> On 04/11/2014 01:13 AM, Michael McMahon wrote:
>>>> Hi,
>>>>
>>>> This is the webrev for the 8u20 version of the fix that was reviewed
>>>> yesterday for 9.
>>>>
>>>> JDK
>>>> ===
>>>> http://cr.openjdk.java.net/~michaelm/8036979.8u20/jdk/01/webrev/
>>>>
>>>> Top repo
>>>> =====
>>>> http://cr.openjdk.java.net/~michaelm/8036979.8u20/top/01/webrev/
>>>>
>>>> The good news is that the change is almost the same as the JDK 9 
>>>> version
>>>> with the following differences:
>>>>
>>>> 1) The java.net public API changes are gone. The new public methods
>>>> for 9
>>>>      in SocketImpl and DatagramSocketImpl are package private here.
>>>>
>>>> 2) A new package private class java.net.SocketsUtil acts as a bridge
>>>> between
>>>>     the public API in jdk.net.Sockets and the implementation in 
>>>> java.net
>>>>
>>>> 3) jdk.net.Sockets uses reflection to access the methods of
>>>> java.net.SocketsUtil
>>>>
>>>> 4) The test of the public java.net API is gone and the other test
>>>> augmented
>>>>     with some additional tests for the standard socket options
>>>>
>>>> Thanks,
>>>> Michael
>>>>
>>>
>>