RFR JDK-8027308: HttpURLConnection should better handle URLs with literal IPv6 addresses

[Chris Hegarty]

Pavel,

This looks much better. Just a few small comments on the test.

1) You can probably add an @summary tag with the bug synopsis.

2) The test should not use a hardcoded port, 7666. Otherwise it cannot be run concurrently on the same machine, or may collide with another test/service.

        httpServer = HttpServer.create(new InetSocketAddress(address, 0), 0);
        httpServer.getAddress();

3) I think the test should check that the network interface isUp().

-Chris.
 
On 9 Jun 2014, at 18:06, Pavel Rappo <pavel.rappo at oracle.com> wrote:

> Alan, it looks simpler, indeed:
> 
> http://cr.openjdk.java.net/~prappo/8027308/webrev.01/src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java.sdiff.html
> 
> I have removed the StringBuilder completely. It doesn't seem to be a performance critical part of the code :) But from the readability perspective this is a lot better.
> 
> -Pavel
> 
> On 9 Jun 2014, at 07:49, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
>> On 09/06/2014 06:40, Chris Hegarty wrote:
>>> This looks good to me Pavel.
>>> 
>>> -Chris.
>> It looks okay to me too, I was just wondering if it would be simpler to use host.substring + sb.append(']').
>> 
>> -Alan
>> 
>