RFR 8046588: test for SO_FLOW_SLA availability does not check for EACCESS

Alan Bateman Alan.Bateman at oracle.com
Fri Jun 13 11:10:04 UTC 2014


On 13/06/2014 11:49, Michael McMahon wrote:
>
> Okay. I can see the reasoning why supportedOptions should refer to the 
> platform rather than the process/instance
> running. We could consider adding a sub-class of IOException for 
> permission related failures, but I'm not proposing
> to do that here. For now, I'll just ensure that the error message 
> conveys the permission problem.
>
> New webrev: http://cr.openjdk.java.net/~michaelm/8046588/webrev.2/
>
> We also need to check for EPERM. Apparently, there are some codepaths 
> that use that instead
> of EACCES.
For the test change then does it mean that a genuine failure will cause 
the test to pass? I don't like change exception messages but I just 
wonder if this test might have to resort to that to avoid passing then 
there is another problem.

-Alan


More information about the net-dev mailing list