RFR: 8029607 Type of Service (TOS) cannot be set in IPv6 header

Alan Bateman Alan.Bateman at oracle.com
Wed Jun 25 12:09:18 UTC 2014


On 25/06/2014 12:21, Michael McMahon wrote:
> Could I get the following change reviewed please?
>
> http://cr.openjdk.java.net/~michaelm/8029607/webrev.1/

This mostly looks good to me. I assume you have run the :jdk_nio tests 
and also run them with -vmoption:-Djava.net.preferIPv4Stack=true to make 
sure that there aren't any existing tests that need to be updated.

An inconsistency is that net_util_md.h is defining IPV6_TCLASS if not 
already defined whereas genSocketOptionRegistry.c is not. As IPV6_TCLASS 
has been defined for many years then the the #define in net_util_md.h 
might not be needed.

A minor nit in net_util_md.c where L1320 could be s/IPV4/IPv4 and at 
L1337 then the second line of parameters is mis-aligned.

Another minor nit on Net.c L438, probably best to split this over 3 
lines to avoid the inconsistent line length.

-Alan.





More information about the net-dev mailing list