RFR: [8036088] - Thread-unsafe strtok() is used to parse the list of overrides

Ivan Gerasimov ivan.gerasimov at oracle.com
Mon Mar 3 08:32:16 PST 2014


Hello!

The strtok() function is used in 
./windows/native/sun/net/spi/DefaultProxySelector.c.
This function is not thread safe, so it may potentially cause a problem.

The failure in this particular place would be very unlikely, because 
this code should be executed only once during initialization.
Therefore, no regtest provided.

The fix would be to use a thread-safe equivalent, which is strtok_s() 
under Windows.

Would you please help review this simple fix?

BUGURL: https://bugs.openjdk.java.net/browse/JDK-8036088
WEBREV: http://cr.openjdk.java.net/~igerasim/8036088/0/webrev/

Sincerely yours,
Ivan


More information about the net-dev mailing list