RFR: 8025293 - JNI exception pending checks in java.net
Alan Bateman
Alan.Bateman at oracle.com
Tue Mar 4 05:17:31 PST 2014
On 04/03/2014 11:54, Mark Sheppard wrote:
> Hi Alan,
> thanks for the response. I originally had a CHECK_NULL_RETURN after
> getBraodcast and tests
> failed on Macos, but not on other platforms!
> The issue is that getBroadcast returns NULL when broadcast is not
> available for an interface, or when the ioctl calls
> return an error.
Thanks, I missed the fact that it also returns NULL when there isn't a
broadcast address.
> The former is the case on macos with the loopback lo interface.
> Hence we went with the ExceptionCheck after these calls.
> WRT returning ifs, I just followed the convention created in the
> CHECKED_MALLOC3 macro, as
> ifs is an "in" parameter.
Got it, it just means that each addif usage needs to check for a JNI
exception and that seems to be the case.
-Alan.
More information about the net-dev
mailing list