RFR: JDK8036601 - NI exception pending in jdk/src/windows/native/sun/net/dns/ResolverConfigurationImpl.c

Alan Bateman Alan.Bateman at oracle.com
Wed Mar 12 16:51:50 UTC 2014


On 12/03/2014 16:43, Mark Sheppard wrote:
> Hi
>    please oblige and review the following changes
> http://cr.openjdk.java.net/~msheppar/8036601/webrev/
This mostly looks good to me.

One observation is that is the return from loadConfig isn't clear. What 
would you think about adding STS_ERROR (-1) so that it's clear from 
loadConfig and the caller that this is the error case. In the original 
code there ere several status values and the IS_XXX macros were used to 
check them.

-Alan.


More information about the net-dev mailing list