RFR: JDK-8035631 - JNI exception pending in jdk/src/windows/native/java/net/NetworkInterface_winXP.c

Chris Hegarty chris.hegarty at oracle.com
Fri Mar 21 13:43:47 UTC 2014


This looks ok to me Mark.

You have added a question/comment on L514. Is this intentional?

L555. Not directly related to your changes, but should netaddrP be freed 
there before returning NULL?

-Chris.

On 14/03/14 19:04, Mark Sheppard wrote:
> Hi
>
>    Please oblige and review the following changes
> http://cr.openjdk.java.net/~msheppar/8035631/webrev/
>
> which address the issues raised in
> https://bugs.openjdk.java.net/browse/JDK-8035631
>
> Summary:
> added CHECK_NULL_RETURN after JNI calls
>
> regards
> Mark
>


More information about the net-dev mailing list