RFR [9] 8022450: Fix deprecation warnings in UCharacterDirection.java

[Chris Hegarty]

On 1 May 2014, at 09:16, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> On 01/05/2014 09:01, Chris Hegarty wrote:
>> 8022473 has been logged to request replacements for the deprecated UCharacterEnums, but for now the deprecated warnings from UCharacterDirection should be suppressed.
>> 
>> diff --git a/src/share/classes/sun/net/idn/UCharacterDirection.java b/src/share/classes/sun/net/idn/UCharacterDirection.java
>> --- a/src/share/classes/sun/net/idn/UCharacterDirection.java
>> +++ b/src/share/classes/sun/net/idn/UCharacterDirection.java
>> @@ -32,7 +32,8 @@
>>  //      2005-05-19 Edward Wang
>>  //          - copy this file from icu4jsrc_3_2/src/com/ibm/icu/lang/UCharacterDirection.java
>>  //          - move from package com.ibm.icu.lang to package sun.net.idn
>> -//
>> +//      2014-05-01 Chris Hegarty
>> +//          - add class level @SuppressWarnings("deprecation")
>>    package sun.net.idn;
>>  @@ -45,7 +46,7 @@
>>   * @author Syn Wee Quek
>>   * @stable ICU 2.1
>>   */
>> -
>> + at SuppressWarnings("deprecation")
>>  final class UCharacterDirection implements UCharacterEnums.ECharacterDirection {
>>        // private constructor =========================================
>> 
>> 
> The @SuppressWarnings looks fine, I just wonder about the change log, shouldn't that be removed as it duplicates the hg logs.

All the other five java sources files in this package contain a complete change log, I just added this note for consistency. Also, since there is a shared copyright on this file, I felt it safer to continue the practice of adding to the explicit change log, rather than replying on mercurial history.

-Chris.

> 
> -Alan