RFR: 8062744 jdk.net.Sockets.setOption/getOption does not support IP_TOS

Michael McMahon michael.x.mcmahon at oracle.com
Tue Nov 4 12:05:29 UTC 2014


On 04/11/14 11:18, Chris Hegarty wrote:
> On 4 Nov 2014, at 11:15, Michael McMahon <michael.x.mcmahon at oracle.com> wrote:
>
>> On 04/11/14 11:10, Alan Bateman wrote:
>>> On 04/11/2014 11:00, Michael McMahon wrote:
>>>> Thanks Alan. How about I just split the test and check the option setting behavior in OptionsTest.java
>>>> which doesn't have any reference to the jdk.net.Sockets APIs and then check the Sockets.supportedOptions()
>>>> method in the new test?
>>> That sounds okay too, I assume it's possible to come up with a good name for the new test too.
>>>
>>> -Alan
>> SupportedOptions.java maybe.
> That would be fine, or
>    SupportedOptionsTest.java, or
>    StandardSocketOptionsTest.java
>
> -Chris.

Ok. I've just realised that OptionsTest.java is testing all of the 
legacy option set/get calls
together with the new setOption(), getOption() calls. Problem with this:

1) There is no legacy API for setting IP_TOS on ServerSocket

2) The test is not in 8u-dev (because the setOption/getOption API is 9 only)

So, I'd like to stick with the original test (renamed).

Michael
>> Michael



More information about the net-dev mailing list