RFR: JDK-8058932 - java/net/InetAddress/IPv4Formats.java failed because hello.foo.bar does exist

[Mark Sheppard]

thanks Chris

On 01/10/2014 15:58, Chris Hegarty wrote:
> Reviewed.
>
> -Chris.
>
> On 1 Oct 2014, at 00:01, Dmitry Samersoff <dmitry.samersoff at oracle.com> wrote:
>
>> Looks good for me!
>>
>> -Dmitry
>>
>> On 2014-10-01 02:26, Mark Sheppard wrote:
>>> Thanks Tom and Dmitry
>>>
>>> last up best dressed ...
>>>
>>> .invalid as the test domain is  a good recommendation
>>>
>>> change is now
>>>
>>> --- a/test/java/net/InetAddress/IPv4Formats.java        Tue Sep 30
>>> 13:25:04 2014 +0100
>>> +++ b/test/java/net/InetAddress/IPv4Formats.java        Tue Sep 30
>>> 23:23:46 2014 +0100
>>> @@ -36,7 +36,7 @@
>>>              {"126.1", "126.0.0.1"},
>>>              {"128.50.65534", "128.50.255.254"},
>>>              {"192.168.1.2", "192.168.1.2"},
>>> -            {"hello.foo.bar", null},
>>> +            {"invalidhost.invalid", null},
>>>              {"1024.1.2.3", null},
>>>              {"128.14.66000", null }
>>>
>>>
>>> regards
>>> Mark
>>>
>>>
>>> On 30/09/2014 18:53, Dmitry Samersoff wrote:
>>>> Mark,
>>>>
>>>> It probably should be some-name.invalid
>>>>
>>>> IANA reserve .invalid TLD for tests like this one
>>>>
>>>> see:
>>>>
>>>> http://www.iana.org/assignments/special-use-domain-names/special-use-domain-names.xhtml
>>>>
>>>>
>>>> -Dmitry
>>>>
>>>> On 2014-09-30 19:21, Mark Sheppard wrote:
>>>>> Hi
>>>>>
>>>>> Please oblige and review the following small change to test
>>>>> test/java/net/InetAddress/IPv4Formats.java
>>>>>
>>>>> --- a/test/java/net/InetAddress/IPv4Formats.java        Tue Sep 30
>>>>> 13:25:04 2014 +0100
>>>>> +++ b/test/java/net/InetAddress/IPv4Formats.java        Tue Sep 30
>>>>> 15:11:05 2014 +0100
>>>>> @@ -36,7 +36,7 @@
>>>>>               {"126.1", "126.0.0.1"},
>>>>>               {"128.50.65534", "128.50.255.254"},
>>>>>               {"192.168.1.2", "192.168.1.2"},
>>>>> -            {"hello.foo.bar", null},
>>>>> +            {"somehost.some-domain", null},
>>>>>               {"1024.1.2.3", null},
>>>>>               {"128.14.66000", null }
>>>>>
>>>>> which addresses the issue
>>>>>
>>>>> https://bugs.openjdk.java.net/browse/JDK-8058932
>>>>>
>>>>> ping hello.foo.bar
>>>>>
>>>>> Pinging hello.foo.bar [127.0.53.53] with 32 bytes of data:
>>>>> Reply from 127.0.53.53: bytes=32 time<1ms TTL=128
>>>>> Reply from 127.0.53.53: bytes=32 time<1ms TTL=128
>>>>> Reply from 127.0.53.53: bytes=32 time<1ms TTL=128
>>>>> Reply from 127.0.53.53: bytes=32 time<1ms TTL=128
>>>>>
>>>>> this highlights a DNS configuration issue as indicated in
>>>>> https://www.icann.org/resources/pages/name-collision-2013-12-06-en
>>>>>
>>>>> so we remove foo.bar from the test and replace with somehost.some-domain
>>>>>
>>>>> regards
>>>>> Mark
>>
>> -- 
>> Dmitry Samersoff
>> Oracle Java development team, Saint Petersburg, Russia
>> * I would love to change the world, but they won't give me the sources.