RFR(M): 8060470 : Unify and simplify the implmentations of Inet{4, 6}AddressImpl_getLocalHostName()

Alan Bateman Alan.Bateman at oracle.com
Mon Oct 27 18:27:02 UTC 2014


On 27/10/2014 17:45, Volker Simonis wrote:
> :
> Well, the problem is that already that very file contains code in both
> code conventions (see for example the implementations of 'ping4()'
> and 'Java_java_net_Inet4AddressImpl_isReachable0()' in
> Inet4AddressImpl.c which are mostly indented by two spaces). I have no
> problems to adhere to any convention as long as it is generally
> obeyed. As this does not seemed to be the case in these files, I've
> just chosen what I thought is most appropriate. So to keep a long
> story short - I can either:
>
>   1. indent my changes to four spaces (which will still let the files
> with mixed indentation)
>   2. change all indentation in the file to two spaces
>   3. change all indentation in the file to four spaces
>
> Please just tell me what you'd prefer.
>
We normally use 4 space indent in the library code. There are some 
inconsistencies, I don't know the fully history to understand how we got 
2-space indent but if you can fix it up then that would be great.

-Alan


More information about the net-dev mailing list