RFR [7010989]: Duplicate closure of file descriptors leads to unexpected and incorrect closure of sockets

[Chris Hegarty]

Reviewed.

As you said, this is not the default implementation on recent Windows platforms, but possibly worth fixing so it can be backported to older releases.

On this point, there is potential here for a lot of cleanup, even removal of the TwoStacks implementation in 9. I think this would be a really useful thing to do, as it will greatly simplify the code and make it easier to maintain.

-Chris.

On 9 Sep 2014, at 12:03, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:

> Hello!
> 
> In the implementation of TwoStack sockets on Windows there's is a possibility of trying to close the sockets twice in the case of a failure.
> TwoStack implementation isn't the default one, but it still can be used with jdk7u/8u on old platforms.
> 
> Would you please help review the fix?
> 
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-7010989
> WEBREV: http://cr.openjdk.java.net/~igerasim/7010989/0/webrev/
> 
> Sincerely yours,
> Ivan
>