RFR 8058824: Drop TwoStacks socket implementation in jdk9 [win] - Part I

[Ivan Gerasimov]

Thanks Michael!

On 23.09.2014 13:41, Michael McMahon wrote:
> Hi Ivan,
>
> Did you look at the possibility of removing the TwoStacks class 
> altogether?
> For Solaris/Linux etc. ipv4 only and ipv6/v4 are all handled in the 
> same impl class
> with just a switch at socket creation time, selecting AF_INET or 
> AF_INET6.
>
Yes, trying to merge DualStack with IPv4-only (the remaining part of 
TwoStacks) was planned as the second step.
It's not that straight-forward, so better be done separately from this 
change.

> If there is a good reason to keep the implementations separate then I 
> think
> the class should be renamed to reflect its new purpose.
>
I left it with the old name to make the review simpler.
No problem to rename the files, of course.
I only thought that if we are planing to combine both implementations, 
renaming will not matter that much and only make the things more 
complicated.

Sincerely yours,
Ivan