RFR [9] 8143554: UnsupportedOperationException is not thrown for unsupported options

[Svetlana Nikandrova]

Hi Artem,

thank you for your comments. You are right in both cases. I changed to 
"else if" and removed IAE exception from main().

Please see updated review:

http://cr.openjdk.java.net/~kshefov/8143554/webrev.01/ 
<http://cr.openjdk.java.net/%7Ekshefov/8143554/webrev.01/>

Thank you,
Svetlana

On 03.12.2015 17:02, Artem Smotrakov wrote:
> Hi Svetlana,
>
> I'll leave the mail review to official reviewers, a couple of minor 
> comments about your test.
>
> It seems to work fine, but you may want to use "else if" in 
> UnsupportedOptionsTest.getOption() method because "Unsupported socket 
> type" error can occure in case of supported socket type.
>
> Not sure that IllegalAccessException can be thrown in main() method.
>
> Artem
>
> On 12/03/2015 04:06 PM, Svetlana Nikandrova wrote:
>> Hello,
>>
>> please review a simple fix for:
>> https://bugs.openjdk.java.net/browse/JDK-8143554
>>
>> See webrev here:
>> http://cr.openjdk.java.net/~kshefov/8143554/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Ekshefov/8143554/webrev.00/>
>>
>> Fix added explicit check for option support to getOption and 
>> setOption sockets' methods similar way as it was done prior jdk 9 in 
>> Sockets class.
>> Fix also exposed another problem with sockets' supported options: 
>> JDK-8143923 <https://bugs.openjdk.java.net/browse/JDK-8143923> that 
>> cause new test failure test/java/net/SocketOption/OptionsTest.java. I 
>> added test to the ProblemList.
>>
>> Thank you,
>> Svetlana
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20151204/9502b7c8/attachment.html>