RFR 8131155/9, java/net/NetworkInterface/NetworkInterfaceStreamTest.java failed because of Teredo Tunneling Pseudo-Interface

[Paul Sandoz]

Hi Felix,

Is it correct to filter out all network interfaces on windows platforms?

IIUC that renders the tests testSubNetworkInterfaces and testInetAddresses redundant on windows.

If so it would be useful to document that on those tests.


Some minor suggestions:

  s/isWindows/IS_WINDOWS

Colocate the “isIncluded" with IS_WINDOWS.

Paul.

> On 14 Dec 2015, at 07:53, Felix Yang <felix.yang at oracle.com> wrote:
> 
> Hi all,
>    please review the fix for java/net/NetworkInterface/NetworkInterfaceStreamTest.java. It is necessary to exclude "Teredo Tunneling Pseudo-Interface" whose configuration changes frequently.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8131155
> Webrev: http://cr.openjdk.java.net/~xiaofeya/8131155/webrev.00
> 
> Thanks,
> Felix

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20151214/54e3d722/signature.asc>