RFR 8081678: Add Stream returning methods to classes where there currently exist only Enumeration returning methods

Alan Bateman Alan.Bateman at oracle.com
Wed Jun 3 19:27:54 UTC 2015


On 03/06/2015 17:47, Paul Sandoz wrote:
> :
> Ok, i removed it but added an assert for the array being non-null and containing at least one element. I also refined the documentation of the stream returning method in light of this:
>
>    http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8081678-enumeration-and-stream/webrev/
>
The update looks good.

A minor point on getInetAddresses where the javadoc has been changed to 
"Get an Enumeration ...". I think that would be better as "Returns an 
Enumeration". Same thing in inetAddresses() where "Return" would read a 
bit better (IMO anyway).

A niggle in inetAddresses is that it's got two /**.

I was surprised to see PermissionCollection on the list, I don't know 
how often that is used.

For the tests then @library ../../util/streambootlib doesn't seem right. 
Is it time to move some infrastructure to make it easier to get at in 
other parts of the suite?

-Alan


More information about the net-dev mailing list