[9] RFR: 8129444: "socksProxyVersion" system property is ignored if Socket(Proxy) constructor is used

Artem Smotrakov artem.smotrakov at oracle.com
Fri Jun 26 17:22:29 UTC 2015


Hello,

Please review this fix for 9.

If a socket was created with Socket(Proxy) constructor [1], then it 
doesn't take into account "socksProxyVersion" system property. As a 
result, it is not possible to use SOCKS v4 (v5 is used by default [2]). 
Currently the property is checked only in SocksSocketImpl.connect() method.

This fix updates SocksSocketImpl class to check "socksProxyVersion" 
system property when an instance is created, and in 
SocksSocketImpl.socksBind() method.

Bug: https://bugs.openjdk.java.net/browse/JDK-8129444
Webrev: http://cr.openjdk.java.net/~asmotrak/socks4/webrev.01/

[1] 
http://docs.oracle.com/javase/8/docs/api/java/net/Socket.html#Socket-java.net.Proxy- 

[2] 
http://docs.oracle.com/javase/8/docs/api/java/net/doc-files/net-properties.html

Artem
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20150626/b0be0b2d/attachment.html>


More information about the net-dev mailing list