RFR: JDK-4906983

[Chris Hegarty]

Another minor comment...

While what you have suggested is not incorrect, I’m afraid it is giving the wrong impression about the typical acceptable port ranges. A port of Integer.MAX_VALUE is not all that useful, since it typically maps to a TCP port number ( but not always ). Maybe just remove the valid values from @param port, and add something like the following to MalformedURLException: “.., or the port is a negative number other than -1” ?

-Chris.

On 10 Sep 2015, at 11:13, Chris Hegarty <chris.hegarty at oracle.com> wrote:

> 
> On 8 Sep 2015, at 21:01, Sebastian Sickelmann <sebastian.sickelmann at gmx.de> wrote:
> 
>> Hi,
>> 
>> Please find my small patch[1] to javadoc in java.net.URL that adresses
>> JDK-4906983(javadoc-fix)[2].
>> 
>> I signed the SCA/OCA some time ago. Feel free to check at the OCA
>> Signatures-List[3]
>> 
>> thanks to david buck for hosting this patch on cr.openjdk.java.net.
>> 
>> -- Sebastian Sickelmann
>> 
>> [1] http://cr.openjdk.java.net/~dbuck/4906983.0/
> 
> Just to confirm this is a spec only change, that documents long standing existing behaviour, right?
> 
> I think we should add a minimal testcase to cover this.
> 
> Thanks,
> -Chris.
> 
>> [2] https://bugs.openjdk.java.net/browse/JDK-4906983
>> 
>> [3] http://www.oracle.com/technetwork/community/oca-486395.html
>